From ba200f3c403ecfb9e9bf726ec08a2e9579be6543 Mon Sep 17 00:00:00 2001
From: Christian Colglazier <christian@cacolglazier.com>
Date: Sat, 21 May 2022 22:03:33 -0400
Subject: [PATCH] Refactored variable names

---
 follow_focus.py | 27 ++++++++++++++++-----------
 1 file changed, 16 insertions(+), 11 deletions(-)

diff --git a/follow_focus.py b/follow_focus.py
index ca41e68..c6b4507 100644
--- a/follow_focus.py
+++ b/follow_focus.py
@@ -27,9 +27,11 @@ outer_fillets=2.5
 slant_degree=15.0
 wall_width=1.6
 loop_width=wall_width
-rod_thickness=15.2
-angle=40
+loop_angle=40
+rod_diameter=15.2
 offset=9
+tab_height=7
+tab_width=25
 
 # Gears
 mod=0.8
@@ -39,8 +41,6 @@ large_gear_diameter=8.5
 gear_thinkness=10
 
 # Other
-d=25
-t=7
 mount_gap=2
 
 # Calculated values
@@ -49,13 +49,13 @@ gap = stepper_motor_size * math.sin(math.radians(slant_degree)) / math.sin(math.
 width = math.sqrt(gap**2 + stepper_motor_size**2 - 2*gap*stepper_motor_size*math.cos(math.radians(90)))
 end_x=gap+stepper_motor_size-5
 end_y=-4.3
-outer_ring_diameter=rod_thickness+2*loop_width
-center_x=end_x-math.cos(math.radians(angle))*outer_ring_diameter/2
-center_y=end_y-math.sin(math.radians(angle))*outer_ring_diameter/2
+outer_ring_diameter=rod_diameter+2*loop_width
+center_x=end_x-math.cos(math.radians(loop_angle))*outer_ring_diameter/2
+center_y=end_y-math.sin(math.radians(loop_angle))*outer_ring_diameter/2
 
 def findRodInter(n_x, n_y):
     p = Point(center_x, center_y)
-    c = p.buffer(rod_thickness/2).boundary
+    c = p.buffer(rod_diameter/2).boundary
     l = LineString([(n_x, n_y), (n_x+100*math.cos(math.radians(-slant_degree)), n_y+100*math.sin(math.radians(-slant_degree)))])
     i = c.intersection(l)
 
@@ -73,7 +73,8 @@ def createOutline(ex_amount):
 
     outer_x=center_x+math.cos(math.radians(270-slant_degree))*outer_ring_diameter/2
     outer_y=center_y+math.sin(math.radians(270-slant_degree))*outer_ring_diameter/2
-    base = base.threePointArc((center_x+outer_ring_diameter/2 ,center_y), (outer_x, outer_y)).polarLine(d, 180-slant_degree).vLine(t)
+    base = base.threePointArc((center_x+outer_ring_diameter/2 ,center_y), (outer_x, outer_y))\
+               .polarLine(tab_width, 180-slant_degree).vLine(tab_height)
 
     n_x=base.val().endPoint().toTuple()[0]
     n_y=base.val().endPoint().toTuple()[1]
@@ -81,8 +82,8 @@ def createOutline(ex_amount):
     last_x, last_y = findRodInter(n_x, n_y+mount_gap)
 
     base = base.lineTo(coor_x, coor_y)
-    base = base.threePointArc((center_x+rod_thickness/2, center_y), (last_x, last_y))
-    base = base.polarLine(d, 180-slant_degree).close().extrude(ex_amount)
+    base = base.threePointArc((center_x+rod_diameter/2, center_y), (last_x, last_y))
+    base = base.polarLine(tab_width, 180-slant_degree).close().extrude(ex_amount)
 
     # Fillets
     base = base.edges('|Z and >Y').fillet(outer_fillets)
@@ -169,6 +170,7 @@ fastener = fastener.faces('<<Y[-1]').center(fastener_length,0)\
                                              .finalize().cutBlind(-4)
 fastener = fastener.faces('<<Y[-6]').workplane().circle(5/2).cutThruAll()
 
+# Lid large gear mount point
 lid = lid.faces('>Z[0]').workplane().center(21,-20.15)\
                                     .hLine(t, forConstruction=True)\
                                     .threePointArc((-t,t/2),(0,-t))\
@@ -195,6 +197,9 @@ l_gear = l_gear.translate((21+stepper_center[0],20.15+stepper_center[1]+offset+l
 s_gear = cq.Workplane('XY').gear(SpurGear(module=mod,
                                           teeth_number=11,
                                           width=gear_thinkness))
+
+
+# Stepper motor mount point
 tab_distance = 2
 shaft_diameter = 5
 copy = s_gear.faces('<Z[0]').workplane().vLine(tab_distance, forConstruction=True)\